Skip to content

Update jsx configuration schema #7755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025
Merged

Conversation

nojaf
Copy link
Member

@nojaf nojaf commented Aug 4, 2025

  • "mode" was removed.
  • Added "preserve".

Copy link

pkg-pr-new bot commented Aug 4, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7755

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7755

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7755

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7755

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7755

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7755

commit: a3fb969

@nojaf nojaf requested a review from fhammerschmidt August 4, 2025 12:26
Copy link
Member

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

We really need to tell rescript-vscode to use the correct version for the schema: rescript-lang/rescript-vscode#1110 at some point though.

@nojaf nojaf merged commit fb162b2 into rescript-lang:master Aug 4, 2025
27 checks passed
@nojaf
Copy link
Member Author

nojaf commented Aug 4, 2025

Yeah, that seems a bit more complicated to pull off.
Found microsoft/vscode#127812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants