Cleanup the launch_testing_examples. #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make them more robust when run in parallel with other tests. In particular, we make sure that the tests cleanup after themselves, and we also increase the timeouts to 15 seconds. Signed-off-by: Chris Lalancette <[email protected]>
fujitatomoya
reviewed
Mar 8, 2024
launch_testing/launch_testing_examples/launch_testing_examples/set_param_launch_test.py
Show resolved
Hide resolved
…/set_param_launch_test.py Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Chris Lalancette <[email protected]>
fujitatomoya
approved these changes
Mar 8, 2024
|
CI:
|
delete-merged-branch
bot
deleted the
clalancette/cleanup-launch-testing-examples
branch
|
I believe that these fixes will also fix up #391, so I'll backport this to Humble and Iron. |
|
@Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Cleanup the launch_testing_examples. This is to make them more robust when run in parallel with other tests. In particular, we make sure that the tests cleanup after themselves, and we also increase the timeouts to 15 seconds. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit 7e07d22) # Conflicts: # launch_testing/launch_testing_examples/package.xml
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Cleanup the launch_testing_examples. This is to make them more robust when run in parallel with other tests. In particular, we make sure that the tests cleanup after themselves, and we also increase the timeouts to 15 seconds. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit 7e07d22)
clalancette
added a commit
that referenced
this pull request
Sep 5, 2024
* Cleanup the launch_testing_examples. This is to make them more robust when run in parallel with other tests. In particular, we make sure that the tests cleanup after themselves, and we also increase the timeouts to 15 seconds. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit 7e07d22) # Conflicts: # launch_testing/launch_testing_examples/package.xml
ahcorde
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Cleanup the launch_testing_examples. This is to make them more robust when run in parallel with other tests. In particular, we make sure that the tests cleanup after themselves, and we also increase the timeouts to 15 seconds. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit 7e07d22) # Conflicts: # launch_testing/launch_testing_examples/package.xml Co-authored-by: Chris Lalancette <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Cleanup the launch_testing_examples. This is to make them more robust when run in parallel with other tests. In particular, we make sure that the tests cleanup after themselves, and we also increase the timeouts to 15 seconds. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit 7e07d22) Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make them more robust when run in parallel with other tests. In particular, we make sure that the tests cleanup after themselves, and we also increase the timeouts to 15 seconds.
This should improve some of the flaky tests in this package, like we see in https://ci.ros2.org/view/nightly/job/nightly_linux_repeated/3385/#showFailuresLink