Rails test framework is not fully set up before running group-specific before blocks #815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before blocks specific to view specs (and possibly controller specs) appear to run before the necessary Rails test framework setup methods. For example:
This will fail, because the @controller instance variable has not been set up by the test framework; this is done by the #setup_with_controller method, which has not yet been called.
It's not entirely clear to me why this changed between 2.10.x and 2.14.x, or the plan to manage this going forward. I'm also not entirely clear how to write specs for this, since I don't know enough about Rspec internals to simulate running a before block from an example block. However, this small change fixes the problem, and all existing specs pass.