Promise.all? behavior

[gtan66]

Hi guys!

I noticed that the implementation of Promise.all? differs from that of JavaScript's Promise.all. It seems like Promise.all? executes the promises in the argument consecutively, whereas JS's Promise.all executes them concurrently, and then resolves when all of them have completed.

Really simple examples to illustrate:

JS example: http://jsbin.com/?html,css,js,console

Ruby example:

def pr10
  Concurrent::Promise.new{
    puts "hi"
    sleep 10
    puts "bye"
  }
end

Concurrent::Promise.all?(pr10,pr10).execute

Output:

Is there a reason for implementing it this way? I see that we are calling Promise.wait in the implementation here. Thanks :)

[pitr-ch]

Hi @gtan66, thank you for submitting the issue. However, we are now working on getting new implementation of Premisses into edge and then into core. The new implementation does not have the issue so unless somebody contributes the enhancement for the old implementation we'll focus on getting the new implementation in. Related to #577.