Skip to content

Add has_key? method to OpenStruct class #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions lib/ostruct.rb
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,30 @@ def delete_field(name, &block)
end
end


# Returns +true+ if the given name is a member of this OpenStruct object, +false+ otherwise.
# The given +name+ is converted to a symbol before checking.
#
# require "ostruct"
# person = OpenStruct.new("name" => "John Smith", :age => 70)
# person.has_key?(:name) # => true
# person.has_key?("age") # => true
# person.has_key?(:phone) # => false
#
# This method can be used to test for the presence of a value without creating
# an accessor method if it doesn't exist:
#
# person = OpenStruct.new
# person.name = "John"
# person.has_key?(:name) # => true
# person.has_key?(:age) # => false
# person.age # => nil (but creates an accessor)
# person.has_key?(:age) # => false
#
def has_key?(name)
@table.has_key?(name.to_sym)
end

InspectKey = :__inspect_key__ # :nodoc:

#
Expand Down
47 changes: 47 additions & 0 deletions test/ostruct/test_ostruct.rb
Original file line number Diff line number Diff line change
Expand Up @@ -431,4 +431,51 @@ def test_performance_warning
)
end
end
def setup
end

def test_has_key_with_symbol
o = OpenStruct.new(name: "John Smith", age: 70, pension: 300)
assert_true o.has_key?(:name)
assert_true o.has_key?(:age)
assert_true o.has_key?(:pension)
assert_false o.has_key?(:address)
end

def test_has_key_with_string
o = OpenStruct.new(name: "John Smith", age: 70, pension: 300)
assert_true o.has_key?("name")
assert_true o.has_key?("age")
assert_true o.has_key?("pension")
assert_false o.has_key?("address")
end

def test_has_key_after_deletion
o = OpenStruct.new(name: "John Smith", age: 70, pension: 300)
o.delete_field(:name)
assert_false o.has_key?(:name)
end

def test_has_key_with_nil_value
o = OpenStruct.new(name: "John Smith", age: 70, pension: 300)
o.pension = nil
assert_true o.has_key?(:pension)
end

def test_has_key_with_new_ostruct
os = OpenStruct.new
assert_false os.has_key?(:any_key)
end

def test_has_key_after_setting_value
o = OpenStruct.new(name: "John Smith", age: 70, pension: 300)
o.phone = "123-456-7890"
assert_true o.has_key?(:phone)
end

def test_has_key_case_sensitivity
o = OpenStruct.new(name: "John Smith", age: 70, pension: 300)
assert_true o.has_key?(:name)
assert_false o.has_key?(:Name)
end
end