Skip to content

Remove excessive #[allow(clippy::missing_inline_in_public_items)] #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/cmse.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ use bitfield::bitfield;

/// Memory access behaviour: determine which privilege execution mode is used and which Memory
/// Protection Unit (MPU) is used.
#[allow(clippy::missing_inline_in_public_items)]
#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AccessType {
/// Access using current privilege level and reading from current security state MPU.
Expand All @@ -55,7 +54,6 @@ pub enum AccessType {

/// Abstraction of TT instructions and helper functions to determine the security and privilege
/// attribute of a target address, accessed in different ways.
#[allow(clippy::missing_inline_in_public_items)]
#[derive(PartialEq, Copy, Clone, Debug)]
pub struct TestTarget {
tt_resp: TtResp,
Expand Down
1 change: 0 additions & 1 deletion src/peripheral/cpuid.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ pub struct RegisterBlock {

/// Type of cache to select on CSSELR writes.
#[cfg(not(armv6m))]
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Copy, Clone, Debug, PartialEq, Eq)]
pub enum CsselrCacheType {
/// Select DCache or unified cache
Expand Down
4 changes: 0 additions & 4 deletions src/peripheral/scb.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ pub struct RegisterBlock {

/// FPU access mode
#[cfg(has_fpu)]
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum FpuAccessMode {
/// FPU is not accessible
Expand Down Expand Up @@ -194,7 +193,6 @@ impl SCB {
}

/// Processor core exceptions (internal interrupts)
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum Exception {
/// Non maskable interrupt
Expand Down Expand Up @@ -260,7 +258,6 @@ impl Exception {
}

/// Active exception number
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum VectActive {
/// Thread mode
Expand Down Expand Up @@ -913,7 +910,6 @@ impl SCB {
}

/// System handlers, exceptions with configurable priority
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
#[repr(u8)]
pub enum SystemHandler {
Expand Down
1 change: 0 additions & 1 deletion src/peripheral/syst.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ pub struct RegisterBlock {
}

/// SysTick clock source
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum SystClkSource {
/// Core-provided clock
Expand Down
1 change: 0 additions & 1 deletion src/register/apsr.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
//! Application Program Status Register

/// Application Program Status Register
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug)]
pub struct Apsr {
bits: u32,
Expand Down
4 changes: 0 additions & 4 deletions src/register/control.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
//! Control register

/// Control register
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug)]
pub struct Control {
bits: u32,
Expand Down Expand Up @@ -82,7 +81,6 @@ impl Control {
}

/// Thread mode privilege level
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum Npriv {
/// Privileged
Expand All @@ -106,7 +104,6 @@ impl Npriv {
}

/// Currently active stack pointer
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum Spsel {
/// MSP is the current stack pointer
Expand All @@ -130,7 +127,6 @@ impl Spsel {
}

/// Whether context floating-point is currently active
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum Fpca {
/// Floating-point context active.
Expand Down
1 change: 0 additions & 1 deletion src/register/faultmask.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
//! Fault Mask Register

/// All exceptions are ...
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum Faultmask {
/// Active
Expand Down
2 changes: 0 additions & 2 deletions src/register/fpscr.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
//! Floating-point Status Control Register

/// Floating-point Status Control Register
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug)]
pub struct Fpscr {
bits: u32,
Expand Down Expand Up @@ -253,7 +252,6 @@ impl Fpscr {
}

/// Rounding mode
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum RMode {
/// Round to Nearest (RN) mode. This is the reset value.
Expand Down
1 change: 0 additions & 1 deletion src/register/primask.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
//! Priority mask register

/// All exceptions with configurable priority are ...
#[allow(clippy::missing_inline_in_public_items)]
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum Primask {
/// Active
Expand Down