-
Notifications
You must be signed in to change notification settings - Fork 118
Open
Labels
T-libsRelevant to the libraries subteam, which will review and decide on the PR/issue.Relevant to the libraries subteam, which will review and decide on the PR/issue.amendmentAmendments to existing guidelinesAmendments to existing guidelinesdisposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.This issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.The final comment period is finished for this PR / Issue.needs-fcpThis change is insta-stable, so needs a completed FCP to proceed.This change is insta-stable, so needs a completed FCP to proceed.
Description
#135 (comment) suggests a nice one:
I've been using
PascalCase!
for macros that expand into types. (e.g.Array![i32; 5; 4; 3]
which expands into[[[i32; 3]; 4]; 5]
)
I did not consider type macros when adding a case convention for macros in C-CASE. I have also never used a type macro myself. Will need to survey the ecosystem and see whether PascalCase!
for type macros would be a good recommendation.
jplatte, petrochenkov, Veykril, IsakSundeSingh, schulzch and 7 more
Metadata
Metadata
Assignees
Labels
T-libsRelevant to the libraries subteam, which will review and decide on the PR/issue.Relevant to the libraries subteam, which will review and decide on the PR/issue.amendmentAmendments to existing guidelinesAmendments to existing guidelinesdisposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.This issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.The final comment period is finished for this PR / Issue.needs-fcpThis change is insta-stable, so needs a completed FCP to proceed.This change is insta-stable, so needs a completed FCP to proceed.