July goals update #1667
Open
July goals update #1667
+1,975
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojeda
reviewed
Aug 1, 2025
Comment on lines
182
to
188
| ## `-Zindirect-branch-cs-prefix`: | ||
|
|
||
| We've discussed whether this needs to be a separate target feature vs. a modifier on the existing `retpoline` one. Josh argued that since having this enabled without retpoline doesn't make sense, it should be a modifier. On the other hand, Miguel mentioned that it would be clearer on the user's side (easier to map the names from GCC and Clang to `rustc` when they're the same and see that we're enabling the same thing in Rust and Linux kernel's `Makefiles`). | ||
|
|
||
| Ultimately, this is a compiler question and should be resolved here: https://github.com/rust-lang/rust/pull/140740 | ||
|
|
||
| Note: `-Cmin-function-alignment` will be another similar case. |
There was a problem hiding this comment.
IIUC this is for things that happened within July, right?
In that case, I would mention that an MCP was requested. I filled it at rust-lang/compiler-team#899 and @davidtwco seconded it already too.
There was a problem hiding this comment.
Thanks! I've added that in. Please let me know if this is good now.
There was a problem hiding this comment.
The MCP is for -Zindirect-branch-cs-prefix (i.e. the subsection one), not -Cmin-function-alignment. The FCP is also completed now (by the way, it may good to mention that in the summary).
ojeda
reviewed
Aug 1, 2025
joshtriplett
reviewed
Aug 3, 2025
There's nothing to expand and it just adds visual noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered