Parse PR comments as Markdown and ignore code and links #300
+200
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would not be compatible with Markdown parsing
|
(Just looking for a sanity check that the list of ignored Markdown elements makes sense). |
jieyouxu
reviewed
Jun 8, 2025
jieyouxu
reviewed
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes command parsing in bors to ignore commands in Markdown code blocks, backticks, links, images, etc. Because
pulldown_cmarkusesCowStrfor the text, I had to get rid of the "zero-copy" errors in the parser, but that way way overkill anyway 😆Fixes: #295