Skip to content

docs: move docs building process to contributor guide #15854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Aug 17, 2025

What does this PR try to resolve?

Pull https://github.com/rust-lang/cargo/blob/71eb84f21aef43c07580c6aed6f806a6299f5042/src/doc/README.md into our contributor guide for visibility.

Also a writing guideline is added to the chapter, as well as some minor polish.

This is created after seeing the contributing frictions in #15838 (comment).

How to test and review this PR?

mdbook serve src/doc/contrib

@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2025
@weihanglo
Copy link
Member Author

cc @zdivelbiss if you have any other suggestion to this guide.

@weihanglo weihanglo changed the title docs(contrib): move docs building process to contributor guide docs: move docs building process to contributor guide Aug 18, 2025
Comment on lines 60 to 65
The templates are located in
<https://github.com/rust-lang/cargo/tree/master/src/doc/man>
and are converted into three formats:

The templates are located in <https://github.com/rust-lang/cargo/tree/master/src/doc/man>
and are converted into three formats:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines are duplicated (probably unintentionally?).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Fixed!

@zdivelbiss
Copy link
Contributor

zdivelbiss commented Aug 18, 2025

This looks great! I hadn't known this existed (I have a keen eye when it comes to subconsciously skipping over important documents lol). Hopefully adding it to the contribution guide will help others, too.

Comment on lines 64 to 66
1. Troff man pages --- used by the `cargo help` command,
saved in <https://github.com/rust-lang/cargo/tree/master/src/etc/man>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are also used by distributions to provide man pages which they can install. In the pre-built versions we provide, they are located in $SYSROOT/share/man/man1. (Controlled with the install.mandir bootstrap config option.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Let me know if it is still not good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants