-
Notifications
You must be signed in to change notification settings - Fork 664
Update link and body colors to be WCAG AAA compliant #11556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… compliant), resolves rust-lang#1233
thanks for the PR! due to the number of changes it's a bit hard to review/discuss them individually though. I like some of the changes, but others will probably need a discussion first 😅
|
I just realized that #11523 caused quite a bit of conflict with this PR... sorry! 😞
yeah, I guess that would probably make it easier to review, discuss and rebase them 😅
for the dark mode screenshot that seems okay, but the grey of light yellow in light mode seems a bit off |
This PR updates the following colors to have a contrast ratio of at least 7:1 in the environments in which they are used:
main-color-light
is now slightly darker in light modelink-color
andlink-hover-color
are now darker in light mode and lighter in dark modeIt also updates some colors throughout the application to reference these color variables where applicable.
Look at those links pop!
On the category page, the entire row is now a hoverable and clickable link, so that there is no need to differentiate the title as a link (and thus the accessibility checker is happy)
Listed dependencies and dependents now have increased contrast.
I'm sure you can determine which one is before and after :)
I added underlines in places where differentiating the links from the text via color at a ratio that the checker is happy with is not feasible.
Finally, the size of the tap targets for pagination has been slightly increased to pass a Lighthouse audit.
Tested with the built-in test suite
pnpm test
(which now all pass) as well as with Lighthouse in both dark and light mode.Closes #1233.