Skip to content

tests/dump_db: Add schema.sql to the test #8742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2024
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented May 28, 2024

Instead of only running import.sql on a database with all migrations applied we can run the generated schema.sql file on an empty database. This ensures that the schema and data import scripts are compatible with each other.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (e972a9b) to head (9614c37).

Current head 9614c37 differs from pull request most recent head fefd9a0

Please upload reports for the commit fefd9a0 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8742   +/-   ##
=======================================
  Coverage   88.49%   88.50%           
=======================================
  Files         276      276           
  Lines       27468    27496   +28     
=======================================
+ Hits        24309    24336   +27     
- Misses       3159     3160    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 enabled auto-merge May 28, 2024 08:30
@Turbo87 Turbo87 merged commit 33c563f into rust-lang:main May 28, 2024
@Turbo87 Turbo87 deleted the schema-sql branch May 28, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant