Can't type the letter "s"

[ajgajg1134]

If you go to a docs.rs page, click into the search box the letter "s" doesn't type. (I assume this has something to do with the way "S" is used as a shortcut for search. (Sometimes it just works, I haven't found the pattern, but this page is an example of it not working: https://docs.rs/yup-oauth2/1.0.7/yup_oauth2/?search=)

Tested on Firefox and Chrome on two different Windows machines.

[onur]

Hi @ajgajg1134, thanks for reporting.

rustc used in docs.rs have this issue and I believe @GuillaumeGomez fixed this issue last week (rust-lang/rust#49152). Updating nightly in docs.rs should fix this issue.

[GuillaumeGomez]

I confirm it has been fixed.

[ruuda]

I still cannot type an s in the search box at docs.rs. Will this situation resolve itself automatically at some point, or do all of the bad docs have to be rebuilt?

Related issue (resolved): rust-lang/rust#49075.

[ivanovaleksey]

According to this comment some upgrades should be done on docs.rs side to support fix was made.

[CAD97]

For people dealing with the issue: The search results page doesn't have the issue, so typing anything that isn't an s then waiting will allow you to type ss.

I can confirm that a crate released 4 hours ago's documentation on docs.rs still has this issue, so we're waiting somewhat patiently for a rustdoc update in the docs.rs pipeline (and then a rebuild for every crate's documentation that got built by the bad rustdoc...)

[ivanovaleksey]

@CAD97 is rebuilding everything is possible? I believe just fixing the issue would be enough.
Crates documentation would be updated on new releases.

[CAD97]

@ivanovaleksey Yeah, just updating rustdoc will fix it for new releases, but that also means that any crate that got hit by the issue would have to notice that they did and release a new minor version just to fix the docs.

Either way, for the issue to not happen on any of docs.rs' documentation, the user has to wait for a new build of the documentation, whether that's because all bad documentation was rebuilt automatically or the crate owner pushed a new version (and even then, the old version's documentation is still available).

[sinesc]

This also happens with "-" which expands/closes description blocks.

[z2oh]

Is rebuilding the docs for old crates a possibility? There are lots of crates that still haven't had an update since this bug was fixed.

[jyn514]

@z2oh rebuilding automagically is #464

(also, hi Jeremy 😆)

[jyn514]

Both 's' and '-' are fixed on the latest version.