-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add a couple pthread function definitions and get_sched for musl. #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Thanks! Looks like there's some errors on CI though? |
Hm.. interesting, test coverage without writing a test. Nice. How do I run these tests locally? Fails for me due to not finding |
You need to use the docket containers, check .travis.yml for how the
run_docker script is called.
…On Fri 23. Nov 2018 at 20:39, Markus Wanner ***@***.***> wrote:
Thanks! Looks like there's some errors on CI though?
Hm.. interesting, test coverage without writing a test. Nice.
How do I run these tests locally? Fails for me due to not finding
linux/input.h (for target x86_64-unknown-linux-musl) or linux/module.h
(against default system glibc).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1146 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA3NphyQphDSQR2EgJ62pIN2_8FGPBYXks5uyE7lgaJpZM4Yw40u>
.
|
@bors: r+ |
📌 Commit ac2cfa7 has been approved by |
Add a couple pthread function definitions and get_sched for musl. I missed `pthread_setaffinity_np` for the musl variant, so I added a few missing function declarations for musl.
💔 Test failed - status-travis |
Ah, thanks, I'll try that. |
@bors: retry |
Add a couple pthread function definitions and get_sched for musl. I missed `pthread_setaffinity_np` for the musl variant, so I added a few missing function declarations for musl.
💔 Test failed - status-travis |
ac2cfa7
to
268a282
Compare
I dropped the definitions for functions that musl really doesn't provide, squashed the two commits and rebased onto master. This seems to pass CI just fine, now. Please have another look. |
Looks like you've rebased one commit too much :/ Otherwise LGTM. @alexcrichton this can be merged as is, but maybe the commit should be cherry picked on top of master to avoid modifying the history. |
@bors: r+ |
📌 Commit 268a282 has been approved by |
Add a couple pthread function definitions and get_sched for musl. I missed `pthread_setaffinity_np` for the musl variant, so I added a few missing function declarations for musl.
💔 Test failed - status-travis |
@bors: retry |
Add a couple pthread function definitions and get_sched for musl. I missed `pthread_setaffinity_np` for the musl variant, so I added a few missing function declarations for musl.
☀️ Test successful - status-appveyor, status-travis |
I missed
pthread_setaffinity_np
for the musl variant, so I added a few missing function declarations for musl.