Skip to content

freebsd15: Add ki_uerrmsg to struct kinfo_proc #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neuschaefer
Copy link
Contributor

Description

During the development of FreeBSD 15, a field was added to kinfo_proc. With this PR and #4552, the libc-test suite passes on FreeBSD 15 on ppc64.

Sources

Upstream commit: freebsd/freebsd-src@7212b37

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@tgross35
Copy link
Contributor

@asomers given this does technically break the struct definition, do you want this on stable? I think if this is done, the struct should be marked #[non_exhaustive] at the same time so future similar changes aren't breaking (in 1.0 everything will be #[non_exhaustive]).

The change itself LGTM

@asomers
Copy link
Contributor

asomers commented Jul 28, 2025

This change only affects FreeBSD 15. That release is still under development, and therefore no backwards-compatibility concerns apply. So yes I think we should merge it to libc-0.2.

@tgross35
Copy link
Contributor

Thanks for confirming, that's perfect. I think we should still add #[non_exhaustive] to allow changing padding fields into named fields in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants