Skip to content

OsString helpers #989

Closed
Closed
@RalfJung

Description

@RalfJung

Many of the shims @christianpoveda added recently need to read or write an OsString to/from the interpreter memory. Instead of copying that everywhere, we should have helpers that they can all call.

Moreover, right now these functions go through UTF-8. At least when running on a Unix host, we can do better by using OsStrExt, which gives us a raw byte buffer. We probably still need the UTF-8 code path as a fallback for cross-execution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-shimsArea: This affects the external function shimsC-enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions