Skip to content

enable track-raw-ptr tests on Windows #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,7 @@ environment variable:
help identify latent aliasing issues in code that Miri accepts by default. You
can recognize false positives by "<untagged>" occurring in the message -- this
indicates a pointer that was cast from an integer, so Miri was unable to track
this pointer. Make sure to use a non-Windows target with this flag, as the
Windows runtime makes use of integer-pointer casts.
this pointer.

Some native rustc `-Z` flags are also very relevant for Miri:

Expand Down
2 changes: 1 addition & 1 deletion rust-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
39b841dfe36f90a7cd111e7f0c55f32594f6e578
a2e29d67c26bdf8f278c98ee02d6cc77a279ed2e
1 change: 0 additions & 1 deletion tests/compile-fail/stacked_borrows/raw_tracking.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// compile-flags: -Zmiri-track-raw-pointers
// ignore-windows (FIXME: tracking raw pointers does not work on Windows)
//! This demonstrates a provenance problem that requires tracking of raw pointers to be detected.

fn main() {
Expand Down
1 change: 0 additions & 1 deletion tests/run-pass/btreemap.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// compile-flags: -Zmiri-track-raw-pointers
// ignore-windows (FIXME: tracking raw pointers does not work on Windows)
#![feature(btree_drain_filter)]
use std::collections::{BTreeMap, BTreeSet};
use std::mem;
Expand Down
1 change: 0 additions & 1 deletion tests/run-pass/rc.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// compile-flags: -Zmiri-track-raw-pointers
// ignore-windows (FIXME: tracking raw pointers does not work on Windows)
#![feature(new_uninit)]
#![feature(get_mut_unchecked)]

Expand Down
1 change: 0 additions & 1 deletion tests/run-pass/stacked-borrows/stacked-borrows.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// compile-flags: -Zmiri-track-raw-pointers
// ignore-windows (FIXME: tracking raw pointers does not work on Windows)
#![feature(raw_ref_macros)]
use std::ptr;

Expand Down
1 change: 0 additions & 1 deletion tests/run-pass/vec.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// compile-flags: -Zmiri-track-raw-pointers
// ignore-windows (FIXME: tracking raw pointers does not work on Windows)
// Gather all references from a mutable iterator and make sure Miri notices if
// using them is dangerous.
fn test_all_refs<'a, T: 'a>(dummy: &mut T, iter: impl Iterator<Item = &'a mut T>) {
Expand Down
1 change: 0 additions & 1 deletion tests/run-pass/vecdeque.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// compile-flags: -Zmiri-track-raw-pointers
// ignore-windows (FIXME: tracking raw pointers does not work on Windows)
use std::collections::VecDeque;

fn test_all_refs<'a, T: 'a>(dummy: &mut T, iter: impl Iterator<Item = &'a mut T>) {
Expand Down