Update repr to use the attribute template
#1899
Open
+169
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't really think of a good place to put this, but it didn't really fit with the rule it currently was in.
This more or less repeats what is already said in layout.repr.alignment.intro where it explains that they are modifiers that affect a representation.
This consolidates the rules for how repr values can be combined. This adds a few previously undocumented combinations, and I think all permutations should now be covered.
rustbot
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rules:
layout.repr.attribute.introlayout.repr.attribute.syntaxlayout.repr.attribute.allowed-positionslayout.repr.attribute.duplicateslayout.repr.attribute.combinationslayout.repr.attribute.combinations.transparentlayout.repr.attribute.combinations.rustlayout.repr.attribute.combinations.primitivelayout.repr.attribute.combinations.primitive-clayout.repr.attribute.combinations.primitive-unit-onlylayout.repr.attribute.combinations.align-packedlayout.repr.attribute.combinations.align-packed-rust-or-clayout.repr.attribute.combinations.align-maxlayout.repr.attribute.combinations.packed-minlayout.repr.attribute.combinations.rust-c-dupeRenamed rules:
layout.repr.align-packedis nowlayout.repr.alignment.introlayout.repr.primitive.constraintsplit intolayout.repr.primitive.enum-onlyandlayout.repr.primitive.zero-variantlayout.repr.alignment.enumis nowlayout.repr.alignment.align-enumlayout.repr.alignment.constraint-exclusivesplit intolayout.repr.alignment.pack-transitive-alignedandlayout.repr.alignment.packed-enumlayout.repr.transparent.constraint-exclusivemoved tolayout.repr.attribute.combinations