`safe` is now incorrectly a keyword

[ChayimFriedman2]

Since nobody has listened to my review in #18350, we now (since this PR) treat safe as a keyword, meaning the following creates a parse error:

fn safe() {}

rust-analyzer version: tip of git, unreleased

[lnicola]

Oh sorry, I must have missed your comment in #18350.

[Veykril]

That needs to be marked a contextual keyword

rust-analyzer/xtask/src/codegen/grammar/ast_src.rs

Lines 112 to 114 in 6dc5b32

	#[doc(alias = "WEAK_KEYWORDS")]
	const CONTEXTUAL_KEYWORDS: &[&str] =
	&["macro_rules", "union", "default", "raw", "dyn", "auto", "yeet"];

[ChayimFriedman2]

And while we're at it also address the other comment please.

[lnicola]

Which is the other comment? I can't see any of them.

[ChayimFriedman2]

Oh I didn't submit the review, does GitHub not show comments from unfinished review? 😧

My bad, sorry. Published it now.

[lnicola]

That needs to be marked a contextual keyword

error: unresolved macro safe!

😶

[Veykril]

error: unresolved macro safe!

Whats the context here?

[Veykril]

Note that changing it to contextual will need parser changes as well to do contextual parsing, not keyword parsing (different method)

[lnicola]

I tried to do that (similar to async or another kw), but it wasn't quite right.

[roife]

Oh, sorry, I just came back and saw the comments 😱. I am trying to fix it.