Skip to content

Revert "Use ZWNJ to prevent VSCode from forming ligatures between hints and code" #13923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 10, 2023

Doesn't actually seem to fix the bug, it seems to be theme dependent and I am not sure what causes it
Reverts #13886

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2023
@lnicola
Copy link
Member

lnicola commented Jan 10, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jan 10, 2023

📌 Commit 4267b11 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 10, 2023

⌛ Testing commit 4267b11 with merge 6e89e77...

@bors
Copy link
Contributor

bors commented Jan 10, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 6e89e77 to master...

@bors bors merged commit 6e89e77 into master Jan 10, 2023
@bors bors deleted the revert-13886-inlay-ligatures branch January 10, 2023 17:22
@AaronKutch
Copy link

This (?) fixed the issue I had

@Veykril
Copy link
Member Author

Veykril commented Jan 12, 2023

This was the cause for your problem, it no longer occurs for me either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants