Skip to content

feat: Improve "match to let else" assist #14057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2023
Merged

feat: Improve "match to let else" assist #14057

merged 2 commits into from
Jan 30, 2023

Conversation

jonas-schievink
Copy link
Contributor

Closes #13540

Handles complex let patterns (rather than just idents), and diverging block expressions have their {/} stripped to create nicer code.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2023
@jonas-schievink
Copy link
Contributor Author

@bors r+

@bors
Copy link
Contributor

bors commented Jan 30, 2023

📌 Commit 6321b25 has been approved by jonas-schievink

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 30, 2023

⌛ Testing commit 6321b25 with merge b75803a...

@bors
Copy link
Contributor

bors commented Jan 30, 2023

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing b75803a to master...

@bors bors merged commit b75803a into rust-lang:master Jan 30, 2023
@jonas-schievink jonas-schievink deleted the improve-match-to-let-else branch January 30, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Convert match to let-else" assist should handle non-trivial patterns
3 participants