Skip to content

Implement allow lint diagnostics with expect #18081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Implement allow lint diagnostics with expect #18081

wants to merge 2 commits into from

Conversation

SamRodri
Copy link

@SamRodri SamRodri commented Sep 9, 2024 •
edited
Loading

Makes #[expect(_)] have the same effect on diagnostics as #[allow(_)].

Fixes #18056

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2024
@SamRodri SamRodri mentioned this pull request Sep 9, 2024
Merged
@SamRodri SamRodri marked this pull request as ready for review September 9, 2024 17:21
@SamRodri SamRodri changed the title Disable convention diagnostics with expect Implement allow lint diagnostics with expect Sep 9, 2024
@ChayimFriedman2
Copy link
Contributor

Ideally we will raise a warning when #[expect] is not fulfilled, but I don't think we can do it now because our handling of errors emitting is not complete (nor do I think this should block this PR).

@SamRodri
Copy link
Author

Some of this patch modifies old redundant code that is removed by #18086.

@ChayimFriedman2 ChayimFriedman2 mentioned this pull request Sep 11, 2024
Merged
@bors bors closed this in fd243cd Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[expect(non_snake_case)] is ignored in on-the-fly diagnostics
3 participants
@SamRodri @ChayimFriedman2 @rustbot