fix(load-cargo): load workspace from absolute path #19438
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
snprajwal
force-pushed
the
loadws-relpath
branch
from
371fe76 to
e2ec7b1
Compare
Signed-off-by: Prajwal S N <[email protected]>
|
sigh Windows strikes again... saw #14430, RIP |
snprajwal
force-pushed
the
loadws-relpath
branch
from
e2ec7b1 to
3033ccf
Compare
snprajwal
changed the title
Veykril
reviewed
Mar 24, 2025
Comment on lines
+47
to
+53
| // Use the provided path as is if it is absolute. | ||
| // Otherwise, join it with the current dir path. | ||
| let root = AbsPathBuf::assert_utf8(if root.is_absolute() { | ||
| root.to_path_buf() | ||
| } else { | ||
| std::env::current_dir()?.join(root) | ||
| }); |
There was a problem hiding this comment.
This seems unnecessary?
Quoting the docs of Path::join
If
pathis absolute, it replaces the current path.
path being the argument to join here, that is in our case root. So this change shouldn't do anything here
There was a problem hiding this comment.
Ah, right. In that case, something else locally was breaking the workspace discovery. Apologies for the noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19386
The change does not break the API, or affect crate users with working code.