fix: Inline asm fixes #20210
Merged
fix: Inline asm fixes #20210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to, it's already stored in the `kind`.
…nd make only `asm!()` unsafe
Because apparently, we were not accepting inline asm in item position, completely breaking it.
rustbot
added
the
S-waiting-on-review
|
I feel like recently more of those tests started to timeout. |
It's failing to much. We need to fix it, but my changes are unlikely to be the cause.
|
I disabled the offending test. We need to see what's up with it. |
We need it because `global_asm!()` is an item. It's unfortunate that such thing can slip in and I see no way to automatically catch that, but thankfully analysis-stats on self has caught that.
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
naked_asm!()safe to call.global_asm!()actually work. I'm surprised nobody complained about that.Fixes #20207.