-
Notifications
You must be signed in to change notification settings - Fork 763
Enhance Clang AST dumping #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Clang AST dumping #469
Conversation
This commit extends our existing Clang AST dumping to include more information, such as a cursor's canonical, referenced, and declarations cursors if they exist. It prints out most of the information that libclang gives us directly, but not the information that we attempt to (re)construct on top of the libclang APIs.
I'm kinda wary this could be too verbose for big files, but it's probably easy enough to allow cutting it down with an option if we need so, either here or in a followup. r=me with or without the above, thanks Nick :) |
I already try to only display information if it exists, is valid, and isn't the same as the original cursor or original type. Agreed that we can add a --verbose-clang-ast if we find that we need to in practice. @bors-servo r=emilio |
📌 Commit 42b721d has been approved by |
This can lead to infinite loops with forward declarations and blow the stack.
@bors-servo r=emilio (Added a small commit that fixes a potential infinite recursion when dumping the AST, this is purely code removal) |
📌 Commit 67ba2ad has been approved by |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 67ba2ad has been approved by |
Enhance Clang AST dumping This commit extends our existing Clang AST dumping to include more information, such as a cursor's canonical, referenced, and declarations cursors if they exist. It prints out most of the information that libclang gives us directly, but not the information that we attempt to (re)construct on top of the libclang APIs. r? @emilio or @Yamakaky
☀️ Test successful - status-travis |
This commit extends our existing Clang AST dumping to include more information,
such as a cursor's canonical, referenced, and declarations cursors if they
exist. It prints out most of the information that libclang gives us directly,
but not the information that we attempt to (re)construct on top of the libclang
APIs.
r? @emilio or @Yamakaky