-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
C-bugCategory: Clippy is not doing the correct thingCategory: Clippy is not doing the correct thingE-mediumCall for participation: Medium difficulty level problem and requires some initial experience.Call for participation: Medium difficulty level problem and requires some initial experience.
Description
#4018 fixes the main false positive in or_fn_call
when it comes to things like .or(Some(foo))
, keeping them exempt from the lint. However, in the process it also ignores .or(Some(foo.clone())
, which it shouldn't.
We should have a visitor there that ensures that all expressions are either paths or ctors.
Metadata
Metadata
Assignees
Labels
C-bugCategory: Clippy is not doing the correct thingCategory: Clippy is not doing the correct thingE-mediumCall for participation: Medium difficulty level problem and requires some initial experience.Call for participation: Medium difficulty level problem and requires some initial experience.