Stuttter lint

[oli-obk]

fixes #904

[mcarton]

I'm not sure I like most of the fallout for this one 😕.

[oli-obk]

jup :) the function ones are pretty bad

but some function things like utils::conf::conf_file i found to be a good change... so maybe we limit it to public types/functions?

[mcarton]

Why removing the function here? I like closures for small stuffs but not so much for longer functions.

[oli-obk]

well I can change it back to a function, but we should maybe consider a lint that lints .filter_map(x).flat_map(y) and .filter(z).flat_map(y)

[oli-obk]

updated to not lint on private items.

[oli-obk]

apparently we need another rustup

[oli-obk]

travis hickuped, but cargo test runs through locally

[oli-obk]

rebased, but sth is wrong with regex-macros

[mcarton]

It's been a few days, I've made a PR but they haven't published a new version.

[llogiq]

They just did. @mcarton do you want to update our dependencies?

[oli-obk]

travis likes this now

[mcarton]

But I don't 😧. IMO the potential for false positive is still huge.
@llogiq, @Manishearth ?

[Manishearth]

I'm ... not sure. I don't like the fallout. I'm okay with Allow.

[llogiq]

I'm also a bit worried about swamping the output. The severity of the reported problem is low, and the chance for this lint to trigger is high. So even with a fairly low rate of false positive, we will still swamp out reports of higher-severity problems.

As an #[allow]ed lint, it'd be a no-brainer to merge.

[oli-obk]

done

[llogiq]

Thanks.