-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
Right now, x.py is pretty inconsistent with cargo's CLI. To pass arguments to compiletest, you use --test-args
; to pass arguments to expand-yaml-anchors
you use --args
; to pass arguments to cargo you use CARGOFLAGS. I would like to unify these with the same syntax as cargo:
x test ui -- --force-rerun --ignored
would behave the same asx test ui --test-args --force-rerun --test-args --ignored
todayx run miri -- run --print=sysroot
would behave the same asx run miri --args run --args --print=sysroot
x fix -- --fix-broken
would behave the same asCARGOFLAGS=--fix-broken x fix
today, except that it would only pass it to cargo commands invoked by bootstrap, not when building bootstrap itself (avoiding the "argument --fix-broken not expected" error you'd get today).
aliemjay, workingjubilee, kraktus and jyn514
Metadata
Metadata
Assignees
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)