-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
It looks like some tool testsuites (like clippy
's or rustfmt
's) will ignore the no fail fast option. For example running ./x.py test --no-fail-fast clippy
will stop after compile-test fails, something common in big endian platforms.
If I understand correctly this seems to be because bootstrap is not passing --no-fail-fast
to cargo test
in every tool implementation. Currently, the flag is passed in the Step
trait implementation of some tools (i.e. cargo), right after calling tool::prepare_tool_cargo()
. But others like mentioned clippy or rustfmt are missing it.
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)