-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-strict-provenanceArea: Strict provenance for raw pointersArea: Strict provenance for raw pointersE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Term
and GenericArg
currently store pointers as NonZeroUsize
, which is not ideal:
ptr: NonZeroUsize, |
rust/compiler/rustc_middle/src/ty/mod.rs
Line 846 in 92ad4b4
ptr: NonZeroUsize, |
They should really work with NonNull
pointers and strict provenance APIs like .map_addr
, .mask
, etc.
See a PR fixing a similar issue for some context: #110243 (note: in that one I ended up rewriting the whole thing, I think this issue requires far less changes).
Noratrieb
Metadata
Metadata
Assignees
Labels
A-strict-provenanceArea: Strict provenance for raw pointersArea: Strict provenance for raw pointersE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.