-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Closed
Closed
Copy link
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
This was added in #113948:
rust/src/bootstrap/src/core/builder.rs
Lines 2100 to 2105 in bf86c4f
// set rustc args passed from command line | |
let rustc_args = | |
self.config.cmd.rustc_args().iter().map(|s| s.to_string()).collect::<Vec<_>>(); | |
if !rustc_args.is_empty() { | |
cargo.env("RUSTFLAGS", &rustc_args.join(" ")); | |
} |
The issue is, this is a Cargo
instance, that has a separate rustflags
field. So the RUSTFLAGS env var will be overwritten when this is turned into a Command
. (Unfortunately that conversion does not have a sanity check that would notice a RUSTFLAGS value getting lost.)
Cc @rust-lang/bootstrap
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)