-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-bugCategory: This is a bug.Category: This is a bug.O-AArch64Armv8-A or later processors in AArch64 modeArmv8-A or later processors in AArch64 modeT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Our CI has noticed that llvm/llvm-project@e15d67c broke tests/assembly/aarch64-pointer-auth.rs
:
/var/lib/buildkite-agent/builds/rust-llvm-integrate/llvm-project/rust-llvm-integrate-prototype/tests/assembly/aarch64-pointer-auth.rs:16:11: error: CHECK: expected string not found in input
| // CHECK: hint #25
| ^
| /var/lib/buildkite-agent/builds/rust-llvm-integrate/llvm-project/rust-llvm-integrate-prototype/build/x86_64-unknown-linux-gnu/test/assembly/aarch64-pointer-auth/aarch64-pointer-auth.s:1:1: note: scanning from here
| .text
| ^
| /var/lib/buildkite-agent/builds/rust-llvm-integrate/llvm-project/rust-llvm-integrate-prototype/build/x86_64-unknown-linux-gnu/test/assembly/aarch64-pointer-auth/aarch64-pointer-auth.s:14:18: note: possible intended match here
| .file "aarch64_pointer_auth.ed114bba7a018068-cgu.0"
| ^
|
| Input file: /var/lib/buildkite-agent/builds/rust-llvm-integrate/llvm-project/rust-llvm-integrate-prototype/build/x86_64-unknown-linux-gnu/test/assembly/aarch64-pointer-auth/aarch64-pointer-auth.s
| Check file: /var/lib/buildkite-agent/builds/rust-llvm-integrate/llvm-project/rust-llvm-integrate-prototype/tests/assembly/aarch64-pointer-auth.rs
The only diff in the .s file is this:
--- working 2024-07-16 16:26:17.914057368 -0400
+++ broken 2024-07-16 15:35:19.788461411 -0400
@@ -18,11 +18,7 @@
.type test,@function
test:
.cfi_startproc
- hint #25
- .cfi_negate_ra_state
mov w0, #42
- hint #29
- .cfi_negate_ra_state
ret
.Lfunc_end0:
.size test, .Lfunc_end0-test
So somehow something is causing the hint
instructions to get dropped, which is the only thing the test actually looks for. I'm short on time today, but at least wanted to report this semi-promptly. I may look more soon.
Metadata
Metadata
Assignees
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-bugCategory: This is a bug.Category: This is a bug.O-AArch64Armv8-A or later processors in AArch64 modeArmv8-A or later processors in AArch64 modeT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.