-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Closed
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)Area: Debugging information in compiled programs (DWARF, PDB, etc.)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.WG-debuggingWorking group: Bad Rust debugging experiencesWorking group: Bad Rust debugging experiences
Description
We have a fair bit of code in both src/tools/compiletest
and tests/debuginfo
devoted to handling the 7.X releases of gdb, because those had no built-in Rust support. But as of this year at least, the oldest supported RHEL version is now shipping gdb 8.2 so there's no reason for us to be pretending to support versions of gdb before 8.2.
The dev guide also vaguely indicates that this distinction for lldb shouldn't exist anymore:
https://github.com/rust-lang/rustc-dev-guide/blob/43d83780db545a1ed6d45773312fc578987e3968/src/tests/compiletest.md?plain=1#L216
https://github.com/rust-lang/rustc-dev-guide/blob/43d83780db545a1ed6d45773312fc578987e3968/src/tests/compiletest.md?plain=1#L253-L255
- Delete all the
gdbg
annotations intests/debuginfo
, and convert allgdbr
to justgdb
- Delete all the
lldbg
annotations intests/debuginfo
and convert alllldbr
tolldb
- Check if the tests still pass (you've got a 50/50 shot on this, debuginfo tests are cursed)
- Delete the code in compiletest that handles this "Rust support" version gap for gdb, and for lldb
jieyouxu, nikic and Kobzol
Metadata
Metadata
Assignees
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)Area: Debugging information in compiled programs (DWARF, PDB, etc.)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.WG-debuggingWorking group: Bad Rust debugging experiencesWorking group: Bad Rust debugging experiences