-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed as not planned
Closed as not planned
Copy link
Labels
A-edition-2024Area: The 2024 editionArea: The 2024 editionA-rustfmtArea: RustfmtArea: RustfmtC-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCI-style-nominatedNominated for discussion during a style team meeting.Nominated for discussion during a style team meeting.S-tracking-impl-incompleteStatus: The implementation is incomplete.Status: The implementation is incomplete.T-styleRelevant to the style team, which will review and decide on the PR/issue.Relevant to the style team, which will review and decide on the PR/issue.
Description
This is a tracking issue for changing the indentation level used in formatting assignment/op expressions where the left hand side expression has to be formatted across multiple lines, with the style/formatting changing to indent the right hand side expression relative to the last line of the left hand side expression
About tracking issues
Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Steps
- Implement in nightly Rust 2024.
- Add documentation to the edition guide.
- Add formatting for new syntax to the style guide.
- style-guide: When breaking binops handle multi-line first operand better #119838 (initially applied to all binary expressions regardless of the operator type)
- style-guide: Only use the new binop heuristic for assignments #132369 (adjusted scope to only be applicable with assignment operators)
- Revert style guide rhs break #134975
- Ensure ready for Rust 2024 stabilization.
Unresolved Questions
None.
Implementation history
- style-guide: When breaking binops handle multi-line first operand better #119838
- style-guide: Only use the new binop heuristic for assignments #132369
- rust-lang/style-team#189: rhs-should-use-indent-of-last-line-of-lhs rustfmt#6305
cc @rust-lang/rustfmt @rust-lang/style
Metadata
Metadata
Assignees
Labels
A-edition-2024Area: The 2024 editionArea: The 2024 editionA-rustfmtArea: RustfmtArea: RustfmtC-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCI-style-nominatedNominated for discussion during a style team meeting.Nominated for discussion during a style team meeting.S-tracking-impl-incompleteStatus: The implementation is incomplete.Status: The implementation is incomplete.T-styleRelevant to the style team, which will review and decide on the PR/issue.Relevant to the style team, which will review and decide on the PR/issue.