Add alias 'nonstandard_style' for 'bad_style'

[Manishearth]

@ashleygwilliams mentioned this in her talk today; #[allow(bad_style)] is a rather rebuke-y shame-y annotation on code.

While we do want people to use proper style, it's a useful tool whilst learning to be able to turn off all the extra friction that you deal with that you don't have to. Let's be nicer about it; could we rename this to nonstandard_style and keep bad_style as a backcompat alias?

Unsure if this requires an RFC.

[Manishearth]

(Actual name of alias very bikesheddable, I just picked the first thing that came to mind.)

[skade]

Bikeshed: "relaxed_style" sounds good.

[leonardo-m]

"bad_style" sounds better than "nonstandard_style" because "nonstandard" sounds un-opinionated. The point of a "bad_style" annotation is to help people feel guilty.

[Manishearth]

Right, I'm questioning if that's a good thing. Do we need to? Even nonstandard_style (or in general, any warning-allow) does make you feel guilty, bad_style is just very much like a shaming and feels bad.

[mgattozzi]

Her talk was great. I think using something like relaxed_style or permissive_style would be a better choice then bad_style

[tumdum]

I think that 'any_style' is short and is not passive aggressive at all :)

[steveklabnik]

marking as both @rust-lang/compiler and @rust-lang/lang ; not sure who this falls under, really. Also nominating for discussion; I'm not sure if this requires an RFC or not.

[retep998]

As one of the heaviest users of bad_style (https://github.com/retep998/winapi-rs/blob/dev/src/lib.rs#L9), I'd like to voice my lack of opinion on this matter.

[ashleygwilliams]

i have no opinion on what we alias it as, but i would be very interested in an alias that is less shame-y. i am also very happy to implement once we decide what a good alias is!

[nikomatsakis]

For those readers who (like me) were not familiar with the bad_style group, it refers to a collection of 3 lints that enforce various capitalization conventions (e.g., snake_case methods, SHOUTY_GLOBALS, etc).

I'm in favor of renaming. I like any_style because it's short and easy to spell, but #[deny(any_style)] doesn't make any sense to me. =)

Regarding whether this ought to have an RFC -- I could go either way; if we opt for no RFC, then we ought to at least do a "mini-FCP" here in the issue. TBH I'm not sure what team has ownership of lints though. =) I guess @rust-lang/lang?

[aturon]

I definitely don't feel this needs an RFC. I also wholeheartedly agree that we should change the name.

nonstandard_style or alternative_style seem good to me.