as_num-0.2.2 beta regression

[est31]

as_num version 0.2.2 regressed from stable to beta (full log):

    Compiling as_num v0.2.2 (file:///source)
 error[E0034]: multiple applicable items in scope
    --> src/lib.rs:241:50
     |
 152 | |                     $dest::min() <= n && n <= $dest::max()
     | |______________________________^ multiple `min` found
 ...
 241 |           impl_signed_to_signed_internal!($signed, $signed);
     |  __________________________________________________^

cc @phimuemue

[phimuemue]

I have no experience with this. Do I have to adapt my implementation to help rust finding the appropriate min?

[arielb1]

• Add max and min to Ord #42496 - The function Ord::min was added. I think this is an acceptable regression.

@phimuemue

We added Ord::min (and Ord::max) functions. This broke your code because Rust can't tell whether you want to use its Ord::min or your SignedInt::min. This is unfortunate, but we haven't discovered another way to add functions to the Rust library.

You can do a local work-around by calling <$dest as SignedInt>::min (or <$dest as UnsignedInt>::min), or fix this by renaming your function to something else.

[phimuemue]

I (think I) solved the problem using the <$dest as SignedInt> variant, so I think you can close this issue.

[est31]

@phimuemue thanks!