-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.WG-compiler-performanceWorking group: Compiler PerformanceWorking group: Compiler Performance
Description
The CStore
maintains a cache of decoded item attributes which:
- is an instance of shared mutable state that we'd like to avoid and
- is largely unused at this point because item attributes are also cached via the
item_attrs
query.
The remaining instances where the CrateMetadata::get_item_attrs()
is called directly should not be performance critical. To solve this issue:
- Remove the
attribute_cache
field fromCrateMetadata
and make things compile again - Open a PR so that we can due a performance test in order to verify that this indeed does not regress compile times.
cc @rust-lang/wg-compiler-performance
LifeIsStrange
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.WG-compiler-performanceWorking group: Compiler PerformanceWorking group: Compiler Performance