-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Closed
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.C-future-incompatibilityCategory: Future-incompatibility lintsCategory: Future-incompatibility lintsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-help-wantedCall for participation: Help is requested to fix this issue.Call for participation: Help is requested to fix this issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
About 10 months ago it was necessary to permit typos to become temporary non-errors due to #60024 slipping into a stable release. Since #60039, the compiler has issued a "this will become an error" warning for a subset of accidentally-allowed uses (Playground):
fn main() {
assert!(true "whatever"); // Intended: error. Currently: warning.
assert!(true;); // Intended: error. Currently: warning.
assert!(true some extra junk); // Intended: error. Currently: error.
}
Version: 1.43.0 2020-02-26 nightly
Since the fix has been in for far longer than the bug, it would be great to close the loop on this by removing the special cases or converting them to errors.
estebank and stepancheg
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.C-future-incompatibilityCategory: Future-incompatibility lintsCategory: Future-incompatibility lintsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-help-wantedCall for participation: Help is requested to fix this issue.Call for participation: Help is requested to fix this issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.