Highlighting assumes a dark background

[alexcrichton]

I've got a terminal with a white background, and the current highlighting makes me very sad:

I would love for this to be magically detected and not turned on by default for me, but I could also live for now with just a flag to disable it. I don't want to have to disable colors completely, though!

ping @kud1ing, @cmr

[lilyball]

I have an open PR that fixes this already, #7716.

[alexcrichton]

Oh awesome, thanks so much!

[kud1ing]

I somehow never had a doubt that people would use a darkish background, sorry.
Now we need to come up with a solution for people having yellow, red or green backgrounds.

[lilyball]

PR #7716 handles all background colors. Same solution as clang, which is to just use bold, which means the default foreground color is still used.

[thestinger]

@kud1ing: if they have yellow, red or green backgrounds I think they'll have switched around the other colours to be sane on that background too. The best solution would be making it configurable, like how ls has LS_COLORS.

@kballard: we use some other colours though

[kud1ing]

@kballard: diagnostic.rs'sdiagnosticcolor() is the remaining place where hard-coded colors might conflict with the user's background color.

[huonw]

#7716 has landed, is this resolved?

[lilyball]

@huonw: The primary complaint has been resolved. There was some grumbling that the diagnostic colors should be configurable as well, but I think that's a separate issue (e.g. that would be a feature, not a bug).

[alexcrichton]

This particular issue has been resolved, if there are more about colors then I agree those should be separate issue.

For posterity it was closed by 68a32aa of #7716