-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
P-highHigh priorityHigh priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Milestone
Description
Several crates are erroring on as_slice/as_mut_slice being added to the array types (unstably).
- https://crater-reports.s3.amazonaws.com/beta-1.48-1/beta-2020-10-09/reg/unicorn_hat_hd-0.2.1/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.48-1/beta-2020-10-09/reg/rgb-0.8.25/log.txt
I suspect this is because method resolution is now seeing the method on arrays, whereas previously we derefed to &mut [T]
and then there was a trait impl on that? There was another similar issue recently, but I forget what the resolution there was.
cc #76118
elichai
Metadata
Metadata
Assignees
Labels
P-highHigh priorityHigh priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.