Skip to content

Split exported_symbols for generic and non-generic symbols #143013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Split exported_symbols for generic and non-generic symbols #143013

merged 1 commit into from
Jul 1, 2025
+86 −37

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jun 25, 2025 •
edited
Loading

This reduces metadata decoder overhead during the monomorphization collector.

@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

bjorn3
bjorn3 commented Jun 25, 2025
View reviewed changes
@bjorn3
Copy link
Member Author

bjorn3 commented Jun 25, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 25, 2025
@bors
Copy link
Collaborator

bors commented Jun 25, 2025

⌛ Trying commit 5e2d5cf with merge f72ce86...

bors added a commit that referenced this pull request Jun 25, 2025
@bors
Auto merge of #143013 - bjorn3:split_exported_symbols, r=<try>
f72ce86 
Split exported_symbols for generic and non-generic symbols

This reduces metadata decoder overhead during the monomorphization collector.

This may help with incremental builds for Zed.
bjorn3
bjorn3 commented Jun 25, 2025
View reviewed changes
compiler/rustc_metadata/src/rmeta/decoder/cstore_impl.rs
// to block export of generics from dylibs, but we must fix
// rust-lang/rust#65890 before we can do that robustly.

syms
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally committed this as part of this PR, but preventing export of generics from dylibs doesn't seem to be necessary anymore.

@bjorn3 bjorn3 force-pushed the split_exported_symbols branch from 5e2d5cf to 0fa3ea6 Compare June 25, 2025 14:36
@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2025

The Miri subtree was changed

cc @rust-lang/miri

@bjorn3
Copy link
Member Author

bjorn3 commented Jun 25, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Jun 25, 2025

⌛ Trying commit 0fa3ea6 with merge 536e35d…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 25, 2025
@rust-bors
Auto merge of #143013 - bjorn3:split_exported_symbols, r=<try>
536e35d 
Split exported_symbols for generic and non-generic symbols

This reduces metadata decoder overhead during the monomorphization collector.

This may help with incremental builds for Zed.
@bjorn3 bjorn3 force-pushed the split_exported_symbols branch from 0fa3ea6 to f859eea Compare June 25, 2025 14:53
@bjorn3
Copy link
Member Author

bjorn3 commented Jun 25, 2025

@bors2 try cancel
@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 25, 2025

Try build cancelled. Cancelled workflows:

@rust-bors
Copy link

rust-bors bot commented Jun 25, 2025

⌛ Trying commit f859eea with merge e9337fc…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 25, 2025
@rust-bors
Auto merge of #143013 - bjorn3:split_exported_symbols, r=<try>
e9337fc 
Split exported_symbols for generic and non-generic symbols

This reduces metadata decoder overhead during the monomorphization collector.

This may help with incremental builds for Zed.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Jun 25, 2025

💔 Test failed

@bjorn3 bjorn3 force-pushed the split_exported_symbols branch from f859eea to aa10411 Compare June 25, 2025 15:36
@bjorn3
Copy link
Member Author

bjorn3 commented Jun 25, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
bors added a commit that referenced this pull request Jun 25, 2025
@bors
Auto merge of #143013 - bjorn3:split_exported_symbols, r=<try>
f4a3654 
Split exported_symbols for generic and non-generic symbols

This reduces metadata decoder overhead during the monomorphization collector.

This may help with incremental builds for Zed.
@bors
Copy link
Collaborator

bors commented Jun 25, 2025

⌛ Trying commit aa10411 with merge f4a3654...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jun 25, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2025
@bjorn3 bjorn3 force-pushed the split_exported_symbols branch from aa10411 to 91f653b Compare June 26, 2025 10:53
@bjorn3
Copy link
Member Author

bjorn3 commented Jun 26, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Jun 26, 2025

⌛ Trying commit 91f653b with merge 2a26fdd…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 26, 2025
@rust-bors
Auto merge of #143013 - bjorn3:split_exported_symbols, r=<try>
2a26fdd 
Split exported_symbols for generic and non-generic symbols

This reduces metadata decoder overhead during the monomorphization collector.

This may help with incremental builds for Zed.
@rust-bors
Copy link

rust-bors bot commented Jun 26, 2025

☀️ Try build successful (CI)
Build commit: 2a26fdd (2a26fdd4b88032152a5497a8b20c6ce91002c8c1, parent: 1e838527f18cd24c81547ce6fbef6815032a80a7)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2a26fdd): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.3% [-0.4%, -0.3%] 2
Improvements ✅
(secondary)		 -0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) -0.3% [-0.4%, -0.3%] 2

Max RSS (memory usage)

Results (primary 4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 4.3% [1.6%, 7.0%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.3% [1.6%, 7.0%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Bootstrap: 691.88s -> 691.293s (-0.08%)
Artifact size: 372.13 MiB -> 372.06 MiB (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 27, 2025
oli-obk
oli-obk reviewed Jun 27, 2025
View reviewed changes
@bjorn3
Split exported_symbols for generic and non-generic symbols
753c73a 
This reduces metadata decoder overhead during the monomorphization collector.
@bjorn3 bjorn3 force-pushed the split_exported_symbols branch from 91f653b to 753c73a Compare June 27, 2025 09:34
@oli-obk
Copy link
Contributor

oli-obk commented Jun 27, 2025

r? @oli-obk

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 27, 2025

📌 Commit 753c73a has been approved by oli-obk

It is now in the queue for this repository.

@rustbot rustbot assigned oli-obk and unassigned lcnr Jun 27, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2025
@bors
Copy link
Collaborator

bors commented Jul 1, 2025

⌛ Testing commit 753c73a with merge 076a0a2...

@bors
Copy link
Collaborator

bors commented Jul 1, 2025

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 076a0a2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 1, 2025
@bors bors merged commit 076a0a2 into rust-lang:master Jul 1, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 1, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 86e05cd (parent) -> 076a0a2 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 076a0a26fd6f4c445647a33d6daaac56f732ac05 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 4540.7s -> 7543.2s (66.1%)
  2. dist-x86_64-apple: 11094.0s -> 7877.4s (-29.0%)
  3. x86_64-apple-1: 7082.3s -> 9079.6s (28.2%)
  4. dist-apple-various: 6755.7s -> 8235.0s (21.9%)
  5. dist-aarch64-apple: 5785.4s -> 6365.4s (10.0%)
  6. dist-x86_64-netbsd: 5153.8s -> 4662.0s (-9.5%)
  7. x86_64-gnu-aux: 6832.5s -> 6181.5s (-9.5%)
  8. x86_64-gnu-llvm-20-2: 5442.5s -> 5930.9s (9.0%)
  9. x86_64-gnu-llvm-20-1: 3766.4s -> 3431.2s (-8.9%)
  10. x86_64-gnu-nopt: 6914.8s -> 7451.2s (7.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bjorn3 bjorn3 deleted the split_exported_symbols branch July 1, 2025 16:27
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (076a0a2): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.2%, 0.3%] 2
Improvements ✅
(primary)		 -0.2% [-0.2%, -0.2%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.2% [-0.2%, -0.2%] 1

Max RSS (memory usage)

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.1% [1.1%, 1.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.1% [-1.1%, -1.1%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary -2.2%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.3% [0.5%, 6.2%] 6
Improvements ✅
(primary)		 -2.2% [-3.6%, -1.2%] 16
Improvements ✅
(secondary)		 -2.8% [-4.3%, -0.7%] 6
All ❌✅ (primary) -2.2% [-3.6%, -1.2%] 16

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 5
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Bootstrap: 460.931s -> 461.796s (0.19%)
Artifact size: 372.21 MiB -> 372.30 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bjorn3 @rustbot @rust-timer @bors @rust-log-analyzer @oli-obk @lcnr