-
Notifications
You must be signed in to change notification settings - Fork 13.5k
tests/ui
: A New Order [22/N]
#143297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kivooeo
wants to merge
2
commits into
rust-lang:master
Choose a base branch
from
Kivooeo:tf22
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−60
Open
tests/ui
: A New Order [22/N]
#143297
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 2 additions & 3 deletions
5
tests/ui/op-assign-builtins-by-ref.rs → tests/ui/binop/compound-assign-by-ref.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 3 additions & 4 deletions
7
tests/ui/once-cant-call-twice-on-heap.rs → tests/ui/closures/fnonce-call-twice-error.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
tests/ui/once-cant-call-twice-on-heap.stderr → ...i/closures/fnonce-call-twice-error.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
tests/ui/opt-in-copy.rs → ...i/traits/copy-requires-all-fields-copy.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
tests/ui/type-inference/direct-self-reference-occurs-check.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
//! Test that occurs check prevents direct self-reference in variable assignment. | ||
//! | ||
//! Regression test for <https://github.com/rust-lang/rust/issues/768>. | ||
|
||
fn main() { | ||
let f; | ||
f = Box::new(f); | ||
//~^ ERROR overflow assigning `Box<_>` to `_` | ||
} |
2 changes: 1 addition & 1 deletion
2
tests/ui/occurs-check.stderr → ...direct-self-reference-occurs-check.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
tests/ui/type-inference/enum-self-reference-occurs-check.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
//! Test that occurs check prevents infinite types with enum self-references. | ||
//! | ||
//! Regression test for <https://github.com/rust-lang/rust/issues/778>. | ||
|
||
enum Clam<T> { | ||
A(T), | ||
} | ||
|
||
fn main() { | ||
let c; | ||
c = Clam::A(c); | ||
//~^ ERROR overflow assigning `Clam<_>` to `_` | ||
match c { | ||
Clam::A::<isize>(_) => {} | ||
} | ||
} |
2 changes: 1 addition & 1 deletion
2
tests/ui/occurs-check-3.stderr → ...e/enum-self-reference-occurs-check.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
//! Test that occurs check prevents infinite types during type inference. | ||
//! | ||
//! Regression test for <https://github.com/rust-lang/rust/issues/768>. | ||
|
||
fn main() { | ||
let f; | ||
let g; | ||
|
||
g = f; | ||
//~^ ERROR overflow assigning `Box<_>` to `_` | ||
f = Box::new(g); | ||
} |
2 changes: 1 addition & 1 deletion
2
tests/ui/occurs-check-2.stderr → ...ference/infinite-type-occurs-check.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you delete something, could you put the reason in the commit message? I'm sure it's fine but describing the reason for a change always takes the guesswork out :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a very basic test that we're testing miltiple times in other places, very simple, if needed I can found same tests in other tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it makes sense; just put that in the first commit message pls :) (to help the next person who looks at the log and has this question)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a description to this moved commit, not sure if this was what you meant, but this is how I understood this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's exactly it :) it's always good practice for a commit message to explain why a change is done