-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Retire hir::*ItemRef. #143357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Retire hir::*ItemRef. #143357
Conversation
1264eb5
to
4e5d3e2
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Retire hir::*ItemRef. r? `@ghost` for perf
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #143390) made this pull request unmergeable. Please resolve the merge conflicts. |
Finished benchmarking commit (2d047d1): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.7%, secondary 0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -4.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 461.527s -> 461.455s (-0.02%) |
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
Changes to the size of AST and/or HIR nodes. cc @nnethercote changes to the core type system Some changes occurred in match checking cc @Nadrieril Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
643804d
to
8063b5b
Compare
This information was kept for various places that iterate on HIR to know about trait-items and impl-items.
This PR replaces them by uses of the
associated_items
query that contain pretty much the same information.This shortens many spans to just
def_span
, which can be easier to read.