compiler: Document and reduce fn provides in hir crates
#143394
+36
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @spastorino rustbot has assigned @spastorino. Use |
rustbot
added
S-waiting-on-review
|
It might also be the case that the inlining should be reversed until there are no more individual queries being assigned in the root |
workingjubilee
force-pushed
the
reorganize-hir-analysis-provide-fn
branch
from
0bcd31a to
1ac1d83
Compare
workingjubilee
changed the title
fn providesfn provides in hir crates
workingjubilee
changed the title
fn provides in hir cratesfn provides in hir crates
|
There was one other one in |
|
Update the comments, then r=me |
|
Also please squash all the inlining commits, since they kinda all do the same thing |
Many small indirections with 1-2 items actively hinders understanding. Inlines various tiny submodule provides into - hir_analysis::provide - hir_analysis::check::provide - hir_typeck::provide
workingjubilee
force-pushed
the
reorganize-hir-analysis-provide-fn
branch
from
1ac1d83 to
3b7f9f9
Compare
|
Done~ |
|
thanks @bors r+ rollup |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it hard to follow all these tiny micro-indirections. Much like you shouldn't pass around
&u32if you can help it, you probably shouldn't use an indirection if the indirection overhead itself is literally bigger than the amount of data you are organizing. Generally a newfn provideamounts to around 3 LOC:rustc_middle::query::ProvidersimportI am not even counting the cost in time and thought to go find the other
provide, read it, understand, "Ah, yes, these functions", and then go to those. Thus I say we should collapse indirections ofprovidefor modules that only export 1~2 queries. For higher-count indirections, I left them as-is, as I don't understand the crate well enough to judge their worth.Then I dropped a pointer to the actual module of interest for all these instances of the same function. I think documenting them is important because the comment that it relates to the query system makes it obvious that they have nothing to do with the rest of the module's logic and I can carry on ignoring them. Actively doing so is another cognitive cost, but much more minimal.
There is also a small correctness issue in that all of these functions are technically mutating state. It's not a huge deal, but it's still easier to check all these mutations do not overlap if we have less instances of
fn provideto check.