test passing a VaList from rust to C
#143397
Open
+104
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-run-make
|
This PR modifies cc @jieyouxu |
beetrees
suggested changes
Jul 3, 2025
folkertdev
force-pushed
the
test-variadic-call-from-rust-to-c
branch
from
6ef0403 to
a956428
Compare
|
@bors2 try jobs=aarch64-gnu,x86_64-msvc-,x86_64-apple- |
rust-bors bot
added a commit
that referenced
this pull request
Jul 4, 2025
… r=<try> test passing a `VaList` from rust to C Have C define various functions that take a `...` or `va_list` as an argument, and call them from rust. As far as I can see, this just wasn't actually tested before. In particular this tests a difference between rust `VaList` and C `va_list` where C uses array-to-pointer decay, but rust cannot. I've locally tested this for - `x86_64-unknown-linux-gnu` - `aarch64-unknown-linux-gnu` - `s390x-unknown-linux-gnu` - `powerpc64-unknown-linux-gnu` - `powerpc64le-unknown-linux-gnu` The latter 2 use an opaque pointer, the first 3 use a single-element array. cc `@beetrees` if you see anything incorrect here r? `@workingjubilee` try-job: aarch64-gnu try-job: x86_64-msvc-* try-job: x86_64-apple-*
|
Ah dang, forgot aarch64-apple... |
|
Unknown command "cancel". |
|
@bors2 try jobs=x86_64-msvc-,x86_64-apple-,aarch64-apple |
rust-bors bot
added a commit
that referenced
this pull request
Jul 4, 2025
… r=<try> test passing a `VaList` from rust to C Have C define various functions that take a `...` or `va_list` as an argument, and call them from rust. As far as I can see, this just wasn't actually tested before. In particular this tests a difference between rust `VaList` and C `va_list` where C uses array-to-pointer decay, but rust cannot. I've locally tested this for - `x86_64-unknown-linux-gnu` - `aarch64-unknown-linux-gnu` - `s390x-unknown-linux-gnu` - `powerpc64-unknown-linux-gnu` - `powerpc64le-unknown-linux-gnu` The latter 2 use an opaque pointer, the first 3 use a single-element array. cc `@beetrees` if you see anything incorrect here r? `@workingjubilee` try-job: x86_64-msvc-* try-job: x86_64-apple-* try-job: aarch64-apple
|
💔 Test failed
|
|
macOS is not happy: Not all our tooling is recent enough for C23. |
folkertdev
force-pushed
the
test-variadic-call-from-rust-to-c
branch
from
a956428 to
a3277a1
Compare
|
@bors2 try jobs=x86_64-msvc-*,x86_64-apple-*,aarch64-apple |
rust-bors bot
added a commit
that referenced
this pull request
Jul 4, 2025
… r=<try> test passing a `VaList` from rust to C Have C define various functions that take a `...` or `va_list` as an argument, and call them from rust. As far as I can see, this just wasn't actually tested before. In particular this tests a difference between rust `VaList` and C `va_list` where C uses array-to-pointer decay, but rust cannot. I've locally tested this for - `x86_64-unknown-linux-gnu` - `aarch64-unknown-linux-gnu` - `s390x-unknown-linux-gnu` - `powerpc64-unknown-linux-gnu` - `powerpc64le-unknown-linux-gnu` The latter 2 use an opaque pointer, the first 3 use a single-element array. cc `@beetrees` if you see anything incorrect here r? `@workingjubilee` try-job: x86_64-msvc-* try-job: x86_64-apple-* try-job: aarch64-apple
|
Looks like a good baseline to have before any refactors, thanks. :) @bors r+ |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have C define various functions that take a
...orva_listas an argument, and call them from rust. As far as I can see, this just wasn't actually tested before.In particular this tests a difference between rust
VaListand Cva_listwhere C uses array-to-pointer decay, but rust cannot.I've locally tested this for
x86_64-unknown-linux-gnuaarch64-unknown-linux-gnus390x-unknown-linux-gnupowerpc64-unknown-linux-gnupowerpc64le-unknown-linux-gnuThe latter 2 use an opaque pointer, the first 3 use a single-element array.
cc @beetrees if you see anything incorrect here
r? @workingjubilee