Do not visit impl-trait when looking for self-type elision. #143450
+109
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
|
This PR changes a file inside |
rustbot
added
S-waiting-on-review
compiler-errors
requested changes
Jul 5, 2025
| @@ -2417,6 +2417,9 @@ impl<'a, 'ast, 'ra, 'tcx> LateResolutionVisitor<'a, 'ast, 'ra, 'tcx> { | |||
| trace!("FindReferenceVisitor inserting res={:?}", lt_res); | |||
| self.lifetime.insert(lt_res); | |||
| } | |||
| } else if let TyKind::ImplTrait(..) = ty.kind { | |||
| // Do not attempt to look inside impl-trait. | |||
There was a problem hiding this comment.
Could you make these FIXMEs that briefly mention the "more principled fix" you mention in the PR description?
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linked ICE happens when self-param lifetime elision triggers on a type that has
&Selfappear in an APIT.This PR is the minimal fix: do not attempt to look inside impl-trait. It should be complemented by a more principled fix where we attach the lifetime elision logic to the rib-based resolution logic. This should lead to better error messages for lifetimes that appear in
fn(&mut Self). (The current error is "invalidselfparameter type".)Fixes #122903