Skip to content

tests/ui: A New Order [0/28] #143908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tests/ui: A New Order [0/28] #143908

wants to merge 2 commits into from
+22 −16

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Jul 13, 2025 •
edited
Loading

Note

Intermediate commits are intended to help review, but will be squashed prior to merge.

These are the some last tests that didn’t make it into the main twenty-eightology of PRs. Part of #133895.

r? @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 13, 2025
jieyouxu
jieyouxu reviewed Jul 17, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, two nits. Please squash the test changes into one commit (i.e. only retain two commits {move, test changes} as discussed previously).

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo Kivooeo force-pushed the tf0 branch 2 times, most recently from 15f3d09 to 33b1dd3 Compare July 17, 2025 10:16
Kivooeo
Kivooeo commented Jul 17, 2025
View reviewed changes
@Kivooeo
cleaned up some tests
c0597fb 
Reverting file name weird-exprs.rs due to its historical use, recognition in community and references
@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jul 17, 2025 •
edited
Loading

@rustbot ready

also can I ask you to update tracking issue's long term block, and remove

Reorganize all the stray tests immediately under tests/ui and place them into suitable subdirectories, improving the tests themselves along the way

from there or strike through, since this one is completed

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 17, 2025
jieyouxu
jieyouxu approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu jieyouxu mentioned this pull request Jul 17, 2025
Open
@jieyouxu
Copy link
Member

also can I ask you to update tracking issue's long term block, and remove

Reorganize all the stray tests immediately under tests/ui and place them into suitable subdirectories, improving the tests themselves along the way

from there or strike through, since this one is completed

Done.

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 17, 2025

📌 Commit c0597fb has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kivooeo @jieyouxu @rustbot @rust-log-analyzer @bors