[Perf] Remove call to hir_attrs in predicates_of

[tiif]

Test how much regression we still have if we remove the call to hir_attrs in predicates_of for #140399

r? ghost

[BoxyUwU]

@bors2 try @rust-timer queue

[rust-bors]

⌛ Trying commit 1c5e8b7 with merge 5be0607…

To cancel the try build, run the command @bors2 try cancel.

[tiif]

ok guess I should remove all the tests.

[Kobzol]

For the perf run tests shouldn't matter. Just PR CI failed.

[tiif]

oh nice :>

[rust-bors]

☀️ Try build successful (CI)
Build commit: 5be0607 (5be06075447bf18e6c61863fe8ebb8282f7fee79, parent: a9fb6103b05c6ad6eee6bed4c0bb5a2e8e1024c6)

[rust-timer]

Finished benchmarking commit (5be0607): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.1%, 0.8%]	53
Regressions ❌ (secondary)	0.5%	[0.1%, 1.2%]	47
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	2
All ❌✅ (primary)	0.4%	[0.1%, 0.8%]	53

Max RSS (memory usage)

Results (primary -1.2%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[1.0%, 7.0%]	3
Improvements ✅ (primary)	-1.2%	[-1.2%, -1.2%]	1
Improvements ✅ (secondary)	-5.3%	[-7.2%, -3.4%]	2
All ❌✅ (primary)	-1.2%	[-1.2%, -1.2%]	1

Cycles

Results (secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 463.188s -> 465.176s (0.43%)
Artifact size: 374.77 MiB -> 374.68 MiB (-0.02%)