-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Implement hash_map
macro
#144070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stifskere
wants to merge
9
commits into
rust-lang:master
Choose a base branch
from
stifskere:feat/macros/hash_map
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−0
Open
Implement hash_map
macro
#144070
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
74f1bfe
feat: hash_map macro
stifskere ff5f201
fix: hash_map macro location
stifskere b5692af
docs: documented hash_map macro
stifskere 4298c58
fix: hash_map macro annotations
stifskere 7f00f34
fix: remove duplicate hash_map_macro feature
stifskere 537c609
fix: add hash_map_macro feature in the crate
stifskere 3720f96
fix: change feature alphabetical order
stifskere b57040d
fix: add documentation feature flag for hash_map!
stifskere 86cb657
chore: change map name inside hash_map macro due to hygiene.
stifskere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't use of this feature (maybe it would make sense to?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it because it makes sense that if you create a hash map you must use it, otherwise don't create it, I don't see the point otherwise.