Skip to content

Make bit ops traits const #144120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make bit ops traits const #144120

wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 18, 2025 •
edited by rustbot
Loading

tracking issue: #144119

r? @fee1-dead

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 18, 2025
@oli-obk oli-obk mentioned this pull request Jul 18, 2025
Closed
3 tasks
@fee1-dead
Copy link
Member

r=me when green

@bors rollup

@fee1-dead
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 18, 2025

📌 Commit ff1fdff has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 20, 2025
@jhpratt
Rollup merge of rust-lang#144120 - oli-obk:const-bitops, r=fee1-dead
5a90c19 
Make bit ops traits const

tracking issue: rust-lang#144119

r? `@fee1-dead`
@jhpratt jhpratt mentioned this pull request Jul 20, 2025
Closed
@clarfonthey
Copy link
Contributor

clarfonthey commented Jul 20, 2025 •
edited
Loading

FWIW: would have been nice if you had noticed the discussion in #143949 and #143802. I was also originally going to separate these traits too, but per @RalfJung's comment (which occurred before this PR was opened), it got added into my PR.

I can rebase on top of this, but there needs to be a better decision about whether bit operations and arithmetic ones should be split into separate feature flags/tracking issues.

@oli-obk oli-obk closed this Jul 20, 2025
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 20, 2025

I forgot that existed, sorry

@fee1-dead
Copy link
Member

Let's merge #143949 instead as that's more comprehensive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oli-obk @fee1-dead @bors @clarfonthey @rustbot